npease/ChatMaps
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

Add Image Detection to RMF (Rich Message Formatting) #79

Merged
LAX18 merged 1 commits from npease-gifs into main 2024-04-17 20:19:47 -09:00
Conversation 2 Commits 1 Files Changed 1
+15 -7
LAX18 commented 2024-04-17 19:03:01 -09:00 (Migrated from github.com)
Copy Link
Copy Source

As stated. Works for ".jpg", ".jpeg", ".png", ".gif", ".webp". URL's not ending in those extensions are not detected. The solution is to run a HEAD request on those, but that involves creating a backend API endpoint, and to avoid server overload, moving the image detection from the client recieving messages to the client who sent the message to avoid multiple HEAD requests sent per GIF upload.
image

As stated. Works for ".jpg", ".jpeg", ".png", ".gif", ".webp". URL's not ending in those extensions are not detected. The solution is to run a HEAD request on those, but that involves creating a backend API endpoint, and to avoid server overload, moving the image detection from the client recieving messages to the client who sent the message to avoid multiple HEAD requests sent per GIF upload. ![image](https://github.com/ChatMaps/ChatMaps/assets/34464552/b489611e-eaa7-4dc2-a4b4-c1a25e3939a0)
vercel[bot] commented 2024-04-17 19:03:08 -09:00 (Migrated from github.com)
Copy Link
Copy Source

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
chat-maps ✅ Ready (Inspect) Visit Preview Apr 18, 2024 4:03am
[vc]: #KtjphzVwRRyI5xT2LdBvi1fc2QSNCs0tDl5E+kPYjM8=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJjaGF0LW1hcHMiLCJpbnNwZWN0b3JVcmwiOiJodHRwczovL3ZlcmNlbC5jb20vY2hhdG1hcHMvY2hhdC1tYXBzL0ZtTnBwZ3JpQWlEVUFTUTVtWTFNQjRhRFZCWUwiLCJwcmV2aWV3VXJsIjoiY2hhdC1tYXBzLWdpdC1ucGVhc2UtZ2lmcy1jaGF0bWFwcy52ZXJjZWwuYXBwIiwibmV4dENvbW1pdFN0YXR1cyI6IkRFUExPWUVEIn1dfQ== **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **chat-maps** | ✅ Ready ([Inspect](https://vercel.com/chatmaps/chat-maps/FmNppgriAiDUASQ5mY1MB4aDVBYL)) | [Visit Preview](https://chat-maps-git-npease-gifs-chatmaps.vercel.app) | Apr 18, 2024 4:03am |
ClarkLach (Migrated from github.com) approved these changes 2024-04-17 20:19:46 -09:00
Sign in to join this conversation.
Reviewers
No Reviewers
ClarkLach
Labels
Clear labels
Feature Request
Feature To Be Added
 LGTM-needs-1
LGTM-needs-2
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 security
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
npease (Nicholas Pease)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: npease/ChatMaps#79
Delete Branch "npease-gifs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?